qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: On patch series version tags, and also cover letters (was: [PATCH v2


From: Kshitij Suri
Subject: Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)
Date: Tue, 29 Mar 2022 15:25:39 +0530
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0


On 29/03/22 3:18 pm, Peter Maydell wrote:
On Tue, 29 Mar 2022 at 09:03, Markus Armbruster <armbru@redhat.com> wrote:
A cover letter (git format-patch --cover-letter) lets you write an
introduction to the whole series.  Simple series may not need an
introduction, but complex ones do.  I always use one except when the
"series" is a single patch.
Note that a multi-patch series always needs a cover letter,
even if its contents are quite brief. Some of the automatic
tooling gets confused by multi-patch series with no cover letter.
Conversely, single patches shouldn't have a cover letter, although
getting that one wrong doesn't really have much ill effect.

thanks
-- PMM
Oh so regarding this PNG issue which has 2 patches, one to phase out VNC_PNG and one for core logic, should I send with a cover-letter?

Thank you for our advice!

Regards,

Kshitij Suri




reply via email to

[Prev in Thread] Current Thread [Next in Thread]