Re: [RFC PATCH 1/6] softfloat: add uint128_to_float* conversion methods

[Richard Henderson]

On 3/28/22 14:14, matheus.ferst@eldorado.org.br wrote:
> +        p->frac_hi = shl_double(hi, lo, shift);
> +        if (N > 64) {
> +            p->frac_lo = shl_double(lo, 0, shift);
> +        }

shl_double(x, 0, n) -> x << n.

You could also assign to frac_lo before frac_hi and drop the N > 64 test, though I'm not 
sure if that reads better or not.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~