[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event |
Date: |
Tue, 29 Mar 2022 17:39:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @reason. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 63c30a5378..46580ac551 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -5058,7 +5058,8 @@
> # "data": { "device": "ide0-hd1",
> # "node-name": "#block212",
> # "operation": "write",
> -# "action": "stop" },
> +# "action": "stop",
> +# "reason": "No space left on device" },
> # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
I briefly wondered whether "reason": "No space left on device" implies
"nospace: true, but it looks like it doesn't.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 00/14] Fix some qapi examples and a TODO section, Victor Toso, 2022/03/28
- [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event, Victor Toso, 2022/03/28
- [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event, Victor Toso, 2022/03/28
- Re: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event,
Markus Armbruster <=
- [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO, Victor Toso, 2022/03/28
- [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event, Victor Toso, 2022/03/28
- [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/28
- [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event, Victor Toso, 2022/03/28
- [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/28
- [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/28
- [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events, Victor Toso, 2022/03/28