[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 06/18] hw/cpu/cluster: remove cluster_id now that gdbstub is
From: |
Damien Hedde |
Subject: |
[RFC PATCH 06/18] hw/cpu/cluster: remove cluster_id now that gdbstub is updated |
Date: |
Wed, 30 Mar 2022 14:56:27 +0200 |
Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
---
include/hw/cpu/cluster.h | 7 -------
hw/cpu/cluster.c | 7 -------
2 files changed, 14 deletions(-)
diff --git a/include/hw/cpu/cluster.h b/include/hw/cpu/cluster.h
index 2125765f21..6704434cc0 100644
--- a/include/hw/cpu/cluster.h
+++ b/include/hw/cpu/cluster.h
@@ -60,17 +60,10 @@ OBJECT_DECLARE_TYPE(CPUClusterState, CPUClusterClass,
CPU_CLUSTER)
/**
* CPUClusterState:
- * @cluster_id: The cluster ID. This value is for internal use only and should
- * not be exposed directly to the user or to the guest.
- *
- * State of a CPU cluster.
*/
struct CPUClusterState {
/*< private >*/
CpusState parent_obj;
-
- /*< public >*/
- uint32_t cluster_id;
};
/**
diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c
index 3daf897bd9..51da6ce3a9 100644
--- a/hw/cpu/cluster.c
+++ b/hw/cpu/cluster.c
@@ -42,7 +42,6 @@ static int add_cpu_to_cluster(Object *obj, void *opaque)
static void cpu_cluster_realize(DeviceState *dev, Error **errp)
{
CPUClusterClass *ccc = CPU_CLUSTER_GET_CLASS(dev);
- CPUClusterState *cluster = CPU_CLUSTER(dev);
CpusState *base = CPUS(dev);
Object *cluster_obj = OBJECT(dev);
@@ -64,12 +63,6 @@ static void cpu_cluster_realize(DeviceState *dev, Error
**errp)
/* realize base class (will set cluster field to true) */
ccc->parent_realize(dev, errp);
-
- /*
- * Temporarily copy the cluster id from the base class as
- * gdbstub still uses our field.
- */
- cluster->cluster_id = base->cluster_index;
}
static void cpu_cluster_class_init(ObjectClass *klass, void *data)
--
2.35.1
- [RFC PATCH 00/18] user-creatable cpu clusters, Damien Hedde, 2022/03/30
- [RFC PATCH 04/18] hw/cpu/cluster: make _cpu-cluster_ a subclass of _cpus_, Damien Hedde, 2022/03/30
- [RFC PATCH 02/18] hw/cpu/cpus: introduce _cpus_ device, Damien Hedde, 2022/03/30
- [RFC PATCH 01/18] define MAX_CLUSTERS in cpu.h instead of cluster.h, Damien Hedde, 2022/03/30
- [RFC PATCH 07/18] hw/cpu/cpus: add a common start-powered-off property, Damien Hedde, 2022/03/30
- [RFC PATCH 08/18] hw/arm/arm_cpus: add arm_cpus device, Damien Hedde, 2022/03/30
- [RFC PATCH 03/18] hw/cpu/cpus: prepare to handle cpu clusters, Damien Hedde, 2022/03/30
- [RFC PATCH 05/18] gdbstub: deal with _cpus_ object instead of _cpu-cluster_, Damien Hedde, 2022/03/30
- [RFC PATCH 09/18] hw/arm/xlnx-zynqmp: convert cpu clusters to arm_cpus, Damien Hedde, 2022/03/30
- [RFC PATCH 06/18] hw/cpu/cluster: remove cluster_id now that gdbstub is updated,
Damien Hedde <=
- [RFC PATCH 15/18] hw/riscv/sifive_uµchip_pfsoc: apply riscv_hart_array update, Damien Hedde, 2022/03/30
- [RFC PATCH 11/18] hw/riscv: prepare riscv_hart transition to cpus, Damien Hedde, 2022/03/30
- [RFC PATCH 10/18] hw/riscv/riscv_hart: prepare transition to cpus, Damien Hedde, 2022/03/30
- [RFC PATCH 14/18] hw/riscv/riscv_hart: use cpus as base class, Damien Hedde, 2022/03/30
- [RFC PATCH 17/18] hw/riscv/riscv_hart: remove temporary features, Damien Hedde, 2022/03/30
- [RFC PATCH 18/18] add myself as reviewer of the newly added _cpus_, Damien Hedde, 2022/03/30
- [RFC PATCH 16/18] hw/riscv: update remaining machines due to riscv_hart_array update, Damien Hedde, 2022/03/30
- [RFC PATCH 12/18] hw/riscv/virt: prepare riscv_hart transition to cpus, Damien Hedde, 2022/03/30
- [RFC PATCH 13/18] hw/riscv/spike: prepare riscv_hart transition to cpus, Damien Hedde, 2022/03/30