[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 01/19] migration: Postpone releasing MigrationState.hostname
From: |
Peter Xu |
Subject: |
[PATCH v4 01/19] migration: Postpone releasing MigrationState.hostname |
Date: |
Thu, 31 Mar 2022 11:08:39 -0400 |
We used to release it right after migrate_fd_connect(). That's not good
enough when there're more than one socket pair required, because it'll be
needed to establish TLS connection for the rest channels.
One example is multifd, where we copied over the hostname for each channel
but that's actually not needed.
Keeping the hostname until the cleanup phase of migration.
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/channel.c | 1 -
migration/migration.c | 5 +++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/migration/channel.c b/migration/channel.c
index c4fc000a1a..c6a8dcf1d7 100644
--- a/migration/channel.c
+++ b/migration/channel.c
@@ -96,6 +96,5 @@ void migration_channel_connect(MigrationState *s,
}
}
migrate_fd_connect(s, error);
- g_free(s->hostname);
error_free(error);
}
diff --git a/migration/migration.c b/migration/migration.c
index 695f0f2900..281d33326b 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1809,6 +1809,11 @@ static void migrate_fd_cleanup(MigrationState *s)
qemu_bh_delete(s->cleanup_bh);
s->cleanup_bh = NULL;
+ if (s->hostname) {
+ g_free(s->hostname);
+ s->hostname = NULL;
+ }
+
qemu_savevm_state_cleanup();
if (s->to_dst_file) {
--
2.32.0
- [PATCH v4 08/19] migration: Add postcopy-preempt capability, (continued)
- [PATCH v4 08/19] migration: Add postcopy-preempt capability, Peter Xu, 2022/03/31
- [PATCH v4 12/19] migration: Create the postcopy preempt channel asynchronously, Peter Xu, 2022/03/31
- [PATCH v4 11/19] migration: Postcopy recover with preempt enabled, Peter Xu, 2022/03/31
- [PATCH v4 14/19] migration: Add helpers to detect TLS capability, Peter Xu, 2022/03/31
- [PATCH v4 17/19] tests: Add postcopy tls migration test, Peter Xu, 2022/03/31
- [PATCH v4 15/19] migration: Export tls-[creds|hostname|authz] params to cmdline too, Peter Xu, 2022/03/31
- [PATCH v4 10/19] migration: Postcopy preemption enablement, Peter Xu, 2022/03/31
- [PATCH v4 18/19] tests: Add postcopy tls recovery migration test, Peter Xu, 2022/03/31
- [PATCH v4 13/19] migration: Parameter x-postcopy-preempt-break-huge, Peter Xu, 2022/03/31
- [PATCH v4 03/19] migration: Add pss.postcopy_requested status, Peter Xu, 2022/03/31
- [PATCH v4 01/19] migration: Postpone releasing MigrationState.hostname,
Peter Xu <=
- [PATCH v4 02/19] migration: Drop multifd tls_hostname cache, Peter Xu, 2022/03/31
- [PATCH v4 19/19] tests: Add postcopy preempt tests, Peter Xu, 2022/03/31
- [PATCH v4 16/19] migration: Enable TLS for preempt channel, Peter Xu, 2022/03/31