[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1.1 1/9] qapi: fix example of netdev_add command
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v1.1 1/9] qapi: fix example of netdev_add command |
Date: |
Mon, 04 Apr 2022 08:14:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output has the optional member @dnssearch as string type. It
> should be an array of strings instead. Fix it.
"of String objects". Happy to fix this in my tree.
>
> For reference, see NetdevUserOptions.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/net.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index 0d4578bd07..b92f3f5fb4 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -51,7 +51,7 @@
> #
> # -> { "execute": "netdev_add",
> # "arguments": { "type": "user", "id": "netdev1",
> -# "dnssearch": "example.org" } }
> +# "dnssearch": [ { "str": "example.org" } ] } }
> # <- { "return": {} }
> #
> ##
Preferably with the commit message tweak:
Reviewed-by: Markus Armbruster <armbru@redhat.com>