qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/32] qga: replace deprecated g_get_current_time()


From: Damien Hedde
Subject: Re: [PATCH 12/32] qga: replace deprecated g_get_current_time()
Date: Wed, 6 Apr 2022 16:53:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0



On 3/23/22 16:57, marcandre.lureau@redhat.com wrote:
From: Marc-André Lureau <marcandre.lureau@redhat.com>

According to GLib API:
g_get_current_time has been deprecated since version 2.62 and should not
be used in newly-written code. GTimeVal is not year-2038-safe. Use
g_get_real_time() instead.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
  qga/main.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/qga/main.c b/qga/main.c
index b9dd19918e47..1deb0ee2fbfe 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -314,7 +314,6 @@ static void ga_log(const gchar *domain, GLogLevelFlags 
level,
                     const gchar *msg, gpointer opaque)
  {
      GAState *s = opaque;
-    GTimeVal time;
      const char *level_str = ga_log_level_str(level);
if (!ga_logging_enabled(s)) {
@@ -329,9 +328,11 @@ static void ga_log(const gchar *domain, GLogLevelFlags 
level,
  #else
      if (level & s->log_level) {
  #endif
-        g_get_current_time(&time);
+        gint64 t = g_get_real_time();
          fprintf(s->log_file,
-                "%lu.%lu: %s: %s\n", time.tv_sec, time.tv_usec, level_str, 
msg);
+                "%" G_GINT64_FORMAT ".%" G_GINT64_FORMAT
+                ": %s: %s\n", t / G_USEC_PER_SEC, t % G_USEC_PER_SEC,
+                level_str, msg);
          fflush(s->log_file);
      }
  }

Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>

--
Damien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]