[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/39] util/log: Rename qemu_log_lock to qemu_log_trylock
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 07/39] util/log: Rename qemu_log_lock to qemu_log_trylock |
Date: |
Tue, 12 Apr 2022 21:38:33 +0100 |
User-agent: |
mu4e 1.7.12; emacs 28.1.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> This function can fail, which makes it more like ftrylockfile
> or pthread_mutex_trylock than flockfile or pthread_mutex_lock,
> so rename it.
>
> To closer match the other trylock functions, release rcu_read_lock
> along the failure path, so that qemu_log_unlock need not be called
> on failure.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 07/39] util/log: Rename qemu_log_lock to qemu_log_trylock,
Alex Bennée <=