[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming |
|
Date: |
Thu, 14 Apr 2022 14:37:09 -0500 |
|
User-agent: |
NeoMutt/20211029-34-be16c3 |
On Thu, Apr 14, 2022 at 07:57:53PM +0200, Paolo Bonzini wrote:
> Prepare for the next patch, so that the diff is less confusing.
>
> nbd_client_connecting is moved closer to the definition point.
>
> nbd_client_connecting_wait() is kept only for the reconnection
> logic; when it is used to check if a request has to be reissued,
> use the renamed function nbd_client_will_reconnect(). In the
> next patch, the two cases will have different locking requirements.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/nbd.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Yes, this split makes the next patch easier to read ;)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v2 for-7.1 4/9] nbd: keep send_mutex/free_sema handling outside nbd_co_do_establish_connection, (continued)
- [PATCH v2 for-7.1 5/9] nbd: use a QemuMutex to synchronize yanking, reconnection and coroutines, Paolo Bonzini, 2022/04/14
- [PATCH v2 for-7.1 7/9] nbd: move s->state under requests_lock, Paolo Bonzini, 2022/04/14
- [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming, Paolo Bonzini, 2022/04/14
- [PATCH v2 for-7.1 9/9] nbd: document what is protected by the CoMutexes, Paolo Bonzini, 2022/04/14
- [PATCH v2 for-7.1 8/9] nbd: take receive_mutex when reading requests[].receiving, Paolo Bonzini, 2022/04/14
- Re: [PATCH v2 for-7.1 0/9] nbd: actually make s->state thread-safe, Lukas Straub, 2022/04/16