|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v2 for-7.1 2/9] nbd: mark more coroutine_fns |
Date: | Fri, 15 Apr 2022 13:12:53 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 |
14.04.2022 20:57, Paolo Bonzini wrote:
Several coroutine functions in block/nbd.c are not marked as such. This patch adds a few more markers; it is not exhaustive, but it focuses especially on: - places that wake other coroutines, because aio_co_wake() has very different semantics inside a coroutine (queuing after yield vs. entering immediately); - functions with_co_ in their names, to avoid confusion Reviewed-by: Eric Blake<eblake@redhat.com> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
nbd_reply_chunk_iter_receive is forgotten :) Also, many function headers becomes >80 character length, checkpatch should complain. That all is not critical and may be fixed by follow-up. Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org> -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |