Re: [PATCH v10 06/14] target/riscv: rvk: add support for zknd/zkne extension in RV32

[Richard Henderson]

On 4/15/22 19:35, Weiwei Li wrote:
> +target_ulong HELPER(aes32esmi)(target_ulong rs1, target_ulong rs2,
> +                               target_ulong shamt)
> +{
> +    return aes32_operation(shamt, rs1, rs2, true, true);
> +}
> +
> +target_ulong HELPER(aes32esi)(target_ulong rs1, target_ulong rs2,
> +                              target_ulong shamt)
> +{
> +    return aes32_operation(shamt, rs1, rs2, true, false);
> +}
> +
> +target_ulong HELPER(aes32dsmi)(target_ulong rs1, target_ulong rs2,
> +                               target_ulong shamt)
> +{
> +    return aes32_operation(shamt, rs1, rs2, false, true);
> +}
> +
> +target_ulong HELPER(aes32dsi)(target_ulong rs1, target_ulong rs2,
> +                              target_ulong shamt)
> +{
> +    return aes32_operation(shamt, rs1, rs2, false, false);
> +}

Missing REQUIRE_32BIT tests.

r~