[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 20/39] util/log: Drop call to setvbuf
From: |
Richard Henderson |
Subject: |
[PATCH v3 20/39] util/log: Drop call to setvbuf |
Date: |
Sun, 17 Apr 2022 11:30:00 -0700 |
Now that the log buffer is flushed after every qemu_log_unlock,
which includes every call to qemu_log, we do not need to force
line buffering (or unbuffering for windows). Block buffer the
entire loggable unit.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
util/log.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/util/log.c b/util/log.c
index cab0642a7f..caa38e707b 100644
--- a/util/log.c
+++ b/util/log.c
@@ -136,12 +136,6 @@ bool qemu_set_log(int log_flags, Error **errp)
logfile->fd = stderr;
}
-#if defined(_WIN32)
- /* Win32 doesn't support line-buffering, so use unbuffered output. */
- setvbuf(logfile->fd, NULL, _IONBF, 0);
-#else
- setvbuf(logfile->fd, NULL, _IOLBF, 0);
-#endif
log_append = 1;
qatomic_rcu_set(&qemu_logfile, logfile);
}
--
2.25.1
- [PATCH v3 00/39] Logging cleanup and per-thread logfiles, Richard Henderson, 2022/04/17
- [PATCH v3 01/39] util/log: Drop manual log buffering, Richard Henderson, 2022/04/17
- [PATCH v3 11/39] tcg: Pass the locked filepointer to tcg_dump_ops, Richard Henderson, 2022/04/17
- [PATCH v3 03/39] util/log: Return bool from qemu_set_log_filename, Richard Henderson, 2022/04/17
- [PATCH v3 06/39] util/log: Move qemu_log_lock, qemu_log_unlock out of line, Richard Henderson, 2022/04/17
- [PATCH v3 05/39] os-posix: Use qemu_log_enabled, Richard Henderson, 2022/04/17
- [PATCH v3 14/39] accel/tcg: Use cpu_dump_state between qemu_log_trylock/unlock, Richard Henderson, 2022/04/17
- [PATCH v3 20/39] util/log: Drop call to setvbuf,
Richard Henderson <=
- [PATCH v3 10/39] util/log: Remove qemu_log_vprintf, Richard Henderson, 2022/04/17
- [PATCH v3 08/39] hw/xen: Split out xen_pv_output_msg, Richard Henderson, 2022/04/17
- [PATCH v3 09/39] *: Use fprintf between qemu_log_trylock/unlock, Richard Henderson, 2022/04/17
- [PATCH v3 16/39] util/log: Use qemu_log_trylock/unlock in qemu_log, Richard Henderson, 2022/04/17
- [PATCH v3 17/39] util/log: Drop return value from qemu_log, Richard Henderson, 2022/04/17
- [PATCH v3 25/39] include/qemu/log: Move entire implementation out-of-line, Richard Henderson, 2022/04/17
- [PATCH v3 27/39] util/log: Introduce qemu_set_log_filename_flags, Richard Henderson, 2022/04/17
- [PATCH v3 32/39] util/log: Rename logfilename to global_filename, Richard Henderson, 2022/04/17
- [PATCH v3 37/39] util/log: Rename QemuLogFile to RCUCloseFILE, Richard Henderson, 2022/04/17
- [PATCH v3 13/39] exec/log: Remove log_disas and log_target_disas, Richard Henderson, 2022/04/17