Re: [PATCH v1 31/43] hw/loongarch: Add support loongson3 virt machine type.

[Richard Henderson]

On 4/15/22 02:40, Xiaojuan Yang wrote:
> +++ b/configs/devices/loongarch64-softmmu/default.mak
> @@ -0,0 +1,3 @@
> +# Default configuration for loongarch64-softmmu
> +
> +CONFIG_LOONGARCH_VIRT=y

Again, you can't add this file until you're ready to build.

We do get farther that patch 30, ending in

../qemu/hw/loongarch/loongson3.c: In function ‘loongarch_init’:
../qemu/hw/loongarch/loongson3.c:28:39: error: implicit declaration of function 
‘get_system_memory’ [-Werror=implicit-function-declaration]
   28 |     MemoryRegion *address_space_mem = get_system_memory();
      |                                       ^~~~~~~~~~~~~~~~~


Fix that, with proper include of "exec/address-spaces.h", and this can be the point at 
which we're ready to build.

Or you can push a few of these files back into the previous patch so that the build begins 
there, with zero machines registered (which should be ok, because there's no machine 
registered to be tested with qtest, but do double-check that make check succeeds).


r~