Re: [PATCH v4 0/4] util/thread-pool: Expose minimun and maximum size

[Nicolas Saenz Julienne]

On Mon, 2022-04-04 at 10:29 +0100, Stefan Hajnoczi wrote:
> On Fri, Apr 01, 2022 at 11:35:20AM +0200, Nicolas Saenz Julienne wrote:
> > As discussed on the previous RFC[1] the thread-pool's dynamic thread
> > management doesn't play well with real-time and latency sensitive
> > systems. This series introduces a set of controls that'll permit
> > achieving more deterministic behaviours, for example by fixing the
> > pool's size.
> > 
> > We first introduce a new common interface to event loop configuration by
> > moving iothread's already available properties into an abstract class
> > called 'EventLooopBackend' and have both 'IOThread' and the newly
> > created 'MainLoop' inherit the properties from that class.
> > 
> > With this new configuration interface in place it's relatively simple to
> > introduce new options to fix the even loop's thread pool sizes. The
> > resulting QAPI looks like this:
> > 
> >     -object main-loop,id=main-loop,thread-pool-min=1,thread-pool-max=1
> > 
> > Note that all patches are bisect friendly and pass all the tests.
> > 
> > [1] 
> > https://patchwork.ozlabs.org/project/qemu-devel/patch/20220202175234.656711-1-nsaenzju@redhat.com/
> > 
> > @Stefan I kept your Signed-off-by, since the changes trivial/not
> > thread-pool related
> 
> Looks good to me. I will wait for Markus to review the QAPI schema changes.

ping :)

-- 
Nicolás Sáenz