Re: [PATCH] remove -writeconfig

[Daniel P . Berrangé]

On Thu, Apr 14, 2022 at 10:57:21AM -0400, Paolo Bonzini wrote:
> Like -set and -readconfig, it would not really be too hard to
> extend -writeconfig to parsing mechanisms other than QemuOpts.
> However, the uses of -writeconfig are substantially more
> limited, as it is generally easier to write the configuration
> by hand in the first place.  In addition, -writeconfig does
> not even try to detect cases where it prints incorrect
> syntax (for example if values have a quote in them, since
> qemu_config_parse does not support any kind of escaping.
> Just remove it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  docs/about/deprecated.rst       |  7 ------
>  docs/about/removed-features.rst |  6 +++++
>  include/qemu/config-file.h      |  1 -
>  qemu-options.hx                 |  8 ++-----
>  softmmu/climain.c               | 20 ----------------
>  util/qemu-config.c              | 42 ---------------------------------
>  6 files changed, 8 insertions(+), 76 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|