[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 15/41] intc/exynos4210_gic: replace snprintf() with g_strdup_prin
From: |
marcandre . lureau |
Subject: |
[PATCH 15/41] intc/exynos4210_gic: replace snprintf() with g_strdup_printf() |
Date: |
Wed, 20 Apr 2022 17:25:58 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
While at it, replace '%x' with '%u' as suggested by Philippe Mathieu-Daudé.
Also fixes a GCC 12.0.1 -Wformat-overflow false-positive.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/intc/exynos4210_gic.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c
index bc73d1f11524..f8dd719caa1e 100644
--- a/hw/intc/exynos4210_gic.c
+++ b/hw/intc/exynos4210_gic.c
@@ -289,10 +289,6 @@ static void exynos4210_gic_realize(DeviceState *dev, Error
**errp)
Object *obj = OBJECT(dev);
Exynos4210GicState *s = EXYNOS4210_GIC(obj);
SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
- const char cpu_prefix[] = "exynos4210-gic-alias_cpu";
- const char dist_prefix[] = "exynos4210-gic-alias_dist";
- char cpu_alias_name[sizeof(cpu_prefix) + 3];
- char dist_alias_name[sizeof(cpu_prefix) + 3];
SysBusDevice *gicbusdev;
uint32_t n = s->num_cpu;
uint32_t i;
@@ -322,8 +318,10 @@ static void exynos4210_gic_realize(DeviceState *dev, Error
**errp)
*/
assert(n <= EXYNOS4210_NCPUS);
for (i = 0; i < n; i++) {
+ g_autofree char *cpu_alias_name =
g_strdup_printf("exynos4210-gic-alias_cpu%u", i);
+ g_autofree char *dist_alias_name =
g_strdup_printf("exynos4210-gic-alias_dist%u", i);
+
/* Map CPU interface per SMP Core */
- sprintf(cpu_alias_name, "%s%x", cpu_prefix, i);
memory_region_init_alias(&s->cpu_alias[i], obj,
cpu_alias_name,
sysbus_mmio_get_region(gicbusdev, 1),
@@ -333,7 +331,6 @@ static void exynos4210_gic_realize(DeviceState *dev, Error
**errp)
EXYNOS4210_EXT_GIC_CPU_GET_OFFSET(i), &s->cpu_alias[i]);
/* Map Distributor per SMP Core */
- sprintf(dist_alias_name, "%s%x", dist_prefix, i);
memory_region_init_alias(&s->dist_alias[i], obj,
dist_alias_name,
sysbus_mmio_get_region(gicbusdev, 0),
--
2.35.1.693.g805e0a68082a
- [PATCH 10/41] build-sys: drop MSI's QEMU_GA_DISTRO, (continued)
- [PATCH 10/41] build-sys: drop MSI's QEMU_GA_DISTRO, marcandre . lureau, 2022/04/20
- [PATCH 09/41] build-sys: simplify MSI's QEMU_GA_VERSION, marcandre . lureau, 2022/04/20
- [PATCH 11/41] qga: replace usleep() with g_usleep(), marcandre . lureau, 2022/04/20
- [PATCH 12/41] docs: trace-events-all is installed without renaming, marcandre . lureau, 2022/04/20
- [PATCH 14/41] arm/allwinner-a10: replace snprintf() with g_strdup_printf(), marcandre . lureau, 2022/04/20
- [PATCH 13/41] arm/digic: replace snprintf() with g_strdup_printf(), marcandre . lureau, 2022/04/20
- [PATCH 15/41] intc/exynos4210_gic: replace snprintf() with g_strdup_printf(),
marcandre . lureau <=
- [PATCH 16/41] doc/style: CLang -> Clang, marcandre . lureau, 2022/04/20
- [PATCH 17/41] doc/build-platforms: document supported compilers, marcandre . lureau, 2022/04/20
- Re: [PATCH 17/41] doc/build-platforms: document supported compilers, Daniel P . Berrangé, 2022/04/20
- Re: [PATCH 17/41] doc/build-platforms: document supported compilers, Marc-André Lureau, 2022/04/20
- Re: [PATCH 17/41] doc/build-platforms: document supported compilers, Thomas Huth, 2022/04/20
- Re: [PATCH 17/41] doc/build-platforms: document supported compilers, Marc-André Lureau, 2022/04/20
- Re: [PATCH 17/41] doc/build-platforms: document supported compilers, Marc-André Lureau, 2022/04/20
- Re: [PATCH 17/41] doc/build-platforms: document supported compilers, Daniel P . Berrangé, 2022/04/20