Re: [PATCH 40/41] migration/ram: fix clang warning

[Dr. David Alan Gilbert]

* marcandre.lureau@redhat.com (marcandre.lureau@redhat.com) wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> ../migration/ram.c:1292:31: warning: use of bitwise '&' with boolean operands 
> [-Wbitwise-instead-of-logical]
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Yeh that's the same as:
https://lists.gnu.org/archive/html/qemu-devel/2022-04/msg00640.html

Dave

> ---
>  migration/ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 3532f64ecb98..0ef4bd63ebd5 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1289,7 +1289,7 @@ static int save_normal_page(RAMState *rs, RAMBlock 
> *block, ram_addr_t offset,
>                                           offset | RAM_SAVE_FLAG_PAGE));
>      if (async) {
>          qemu_put_buffer_async(rs->f, buf, TARGET_PAGE_SIZE,
> -                              migrate_release_ram() &
> +                              migrate_release_ram() &&
>                                migration_in_postcopy());
>      } else {
>          qemu_put_buffer(rs->f, buf, TARGET_PAGE_SIZE);
> -- 
> 2.35.1.693.g805e0a68082a
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK