Re: [PATCH 33/41] tests: move libqtest.c under libqos/

[Thomas Huth]

On 20/04/2022 15.26, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Since commit a2ce7dbd917 ("meson: convert tests/qtest to meson"),
> libqtest.h is under libqos/ directory. Let's move the .c along with it.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   docs/devel/qtest.rst                | 4 ++--
>   tests/qtest/{ => libqos}/libqtest.c | 4 ++--

This is definitely wrong. libqtest.c is the outer framework for the qtests, 
and should certainly not reside within libqos, i.e. the qtests that are not 
using the libqos framework should not depend on files in libqos.

Not sure why libqtest.h got moved there, but that certainly was a mistake, 
too. Please move libqtest.h back to the tests/qtest/ folder instead.

 Thomas