[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 23/41] include: add qemu/keyval.h
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 23/41] include: add qemu/keyval.h |
|
Date: |
Wed, 20 Apr 2022 16:38:16 +0100 |
|
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Wed, Apr 20, 2022 at 05:26:06PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Do not require the whole option machinery to handle keyval, as it is
> used by QAPI alone, without the option API. And match the associated
> unit name.
Great, I really dislike it when the .h file name doesn't match the
name where I'll find the .c file impl
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu/keyval.h | 14 ++++++++++++++
> include/qemu/option.h | 6 ------
> qapi/qobject-input-visitor.c | 2 +-
> qom/object_interfaces.c | 1 +
> softmmu/vl.c | 1 +
> tests/unit/check-qom-proplist.c | 1 +
> tests/unit/test-forward-visitor.c | 2 +-
> tests/unit/test-keyval.c | 2 +-
> util/keyval.c | 2 +-
> 9 files changed, 21 insertions(+), 10 deletions(-)
> create mode 100644 include/qemu/keyval.h
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 18/41] osdep.h: move qemu_build_not_reached(), (continued)
- [PATCH 20/41] include: move qemu_msync() to osdep, marcandre . lureau, 2022/04/20
- [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN, marcandre . lureau, 2022/04/20
- [PATCH 22/41] include: move qemu_*_exec_dir() to cutils, marcandre . lureau, 2022/04/20
- [PATCH 23/41] include: add qemu/keyval.h, marcandre . lureau, 2022/04/20
- Re: [PATCH 23/41] include: add qemu/keyval.h,
Daniel P . Berrangé <=
- [PATCH 21/41] include: move qemu_fdatasync() to osdep, marcandre . lureau, 2022/04/20
- [PATCH 25/41] tests: remove block/qdict checks from check-qobject.c, marcandre . lureau, 2022/04/20
- [PATCH 24/41] include: move qdict_{crumple,flatten} declarations, marcandre . lureau, 2022/04/20
- [PATCH 26/41] compiler.h: add QEMU_SANITIZE_{ADDRESS,THREAD}, marcandre . lureau, 2022/04/20
- [PATCH 27/41] Use QEMU_SANITIZE_THREAD, marcandre . lureau, 2022/04/20