[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_in
From: |
Richard Henderson |
Subject: |
[PULL 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init |
Date: |
Wed, 20 Apr 2022 11:05:41 -0700 |
This code appears to be trying to make sure there is a logfile.
But that's already true -- the logfile will either be set by -D,
or will be stderr. In either case, not appropriate here.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220417183019.755276-3-richard.henderson@linaro.org>
---
target/hexagon/translate.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c
index b6f541ecb2..98f1452cad 100644
--- a/target/hexagon/translate.c
+++ b/target/hexagon/translate.c
@@ -874,12 +874,6 @@ void hexagon_translate_init(void)
opcode_init();
- if (HEX_DEBUG) {
- if (!qemu_logfile) {
- qemu_set_log(qemu_loglevel);
- }
- }
-
for (i = 0; i < TOTAL_PER_THREAD_REGS; i++) {
hex_gpr[i] = tcg_global_mem_new(cpu_env,
offsetof(CPUHexagonState, gpr[i]),
--
2.34.1
- [PULL 00/39] Logging cleanup and per-thread logfiles, Richard Henderson, 2022/04/20
- [PULL 01/39] util/log: Drop manual log buffering, Richard Henderson, 2022/04/20
- [PULL 05/39] os-posix: Use qemu_log_enabled, Richard Henderson, 2022/04/20
- [PULL 04/39] util/log: Pass Error pointer to qemu_set_log, Richard Henderson, 2022/04/20
- [PULL 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init,
Richard Henderson <=
- [PULL 03/39] util/log: Return bool from qemu_set_log_filename, Richard Henderson, 2022/04/20
- [PULL 07/39] util/log: Rename qemu_log_lock to qemu_log_trylock, Richard Henderson, 2022/04/20
- [PULL 08/39] hw/xen: Split out xen_pv_output_msg, Richard Henderson, 2022/04/20
- [PULL 09/39] *: Use fprintf between qemu_log_trylock/unlock, Richard Henderson, 2022/04/20
- [PULL 13/39] exec/log: Remove log_disas and log_target_disas, Richard Henderson, 2022/04/20
- [PULL 12/39] exec/translator: Pass the locked filepointer to disas_log hook, Richard Henderson, 2022/04/20
- [PULL 06/39] util/log: Move qemu_log_lock, qemu_log_unlock out of line, Richard Henderson, 2022/04/20
- [PULL 10/39] util/log: Remove qemu_log_vprintf, Richard Henderson, 2022/04/20
- [PULL 11/39] tcg: Pass the locked filepointer to tcg_dump_ops, Richard Henderson, 2022/04/20
- [PULL 14/39] accel/tcg: Use cpu_dump_state between qemu_log_trylock/unlock, Richard Henderson, 2022/04/20