[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/25] tests/guest-debug: better handle gdb crashes
From: |
Alex Bennée |
Subject: |
[PULL 25/25] tests/guest-debug: better handle gdb crashes |
Date: |
Wed, 20 Apr 2022 19:08:32 +0100 |
There are a number of GDB's on various distros which fail fairly hard
when attempting to talk to a cross-arch guest. The previous attempt to
catch this was incorrect as the shell will deliver signals as 128+n.
Fix the detection and while we are it improve the logging we dump into
the test output.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reported-by: Gautam Agrawal <gautamnagrawal@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220419091020.3008144-26-alex.bennee@linaro.org>
diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py
index 2e58795a10..d865e46ecd 100755
--- a/tests/guest-debug/run-test.py
+++ b/tests/guest-debug/run-test.py
@@ -92,17 +92,18 @@ def log(output, msg):
result = subprocess.call(gdb_cmd, shell=True, stdout=output)
- # A negative result is the result of an internal gdb failure like
- # a crash. We force a return of 0 so we don't fail the test on
+ # A result of greater than 128 indicates a fatal signal (likely a
+ # crash due to gdb internal failure). That's a problem for GDB and
+ # not the test so we force a return of 0 so we don't fail the test on
# account of broken external tools.
- if result < 0:
- print("GDB crashed? SKIPPING")
+ if result > 128:
+ log(output, "GDB crashed? (%d, %d) SKIPPING" % (result, result - 128))
exit(0)
try:
inferior.wait(2)
except subprocess.TimeoutExpired:
- print("GDB never connected? Killed guest")
+ log(output, "GDB never connected? Killed guest")
inferior.kill()
exit(result)
--
2.30.2
- [PULL 09/25] tests/docker: remove unnecessary filtering of $(DOCKER_IMAGES), (continued)
- [PULL 09/25] tests/docker: remove unnecessary filtering of $(DOCKER_IMAGES), Alex Bennée, 2022/04/20
- [PULL 13/25] tests/tcg: remove CONFIG_LINUX_USER from config-target.mak, Alex Bennée, 2022/04/20
- [PULL 16/25] tests/tcg: list test targets in Makefile.prereqs, Alex Bennée, 2022/04/20
- [PULL 21/25] tests/tcg: remove duplicate sha512-sse case, Alex Bennée, 2022/04/20
- [PULL 08/25] tests/docker: inline variable definitions or move close to use, Alex Bennée, 2022/04/20
- [PULL 14/25] tests/tcg: remove CONFIG_USER_ONLY from config-target.mak, Alex Bennée, 2022/04/20
- [PULL 15/25] tests/tcg: prepare Makefile.prereqs at configure time, Alex Bennée, 2022/04/20
- [PULL 18/25] tests/tcg: isolate from QEMU's config-host.mak, Alex Bennée, 2022/04/20
- [PULL 20/25] tests/tcg: fix non-static build, Alex Bennée, 2022/04/20
- [PULL 24/25] target/i386: fix byte swap issue with XMM register access, Alex Bennée, 2022/04/20
- [PULL 25/25] tests/guest-debug: better handle gdb crashes,
Alex Bennée <=
- [PULL 19/25] tests/docker: remove SKIP_DOCKER_BUILD, Alex Bennée, 2022/04/20
- [PULL 12/25] tests/tcg: add compiler test variables when using containers, Alex Bennée, 2022/04/20
- [PULL 22/25] tests/tcg: add float_convd test, Alex Bennée, 2022/04/20
- [PULL 23/25] tests/tcg: add missing reference files for float_convs, Alex Bennée, 2022/04/20
- [PULL 17/25] tests/tcg: invoke Makefile.target directly from QEMU's makefile, Alex Bennée, 2022/04/20
- [PULL 11/25] tests/docker: do not duplicate rules for hexagon-cross, Alex Bennée, 2022/04/20
- Re: [PULL 00/25] Various testing, doc and gdbstub fixes, Richard Henderson, 2022/04/20