Re: [RFC PATCH v3 1/5] ppc64: Add semihosting support

[Leandro Lupori]

On 4/20/22 15:18, Richard Henderson wrote:
> [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você 
> possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de 
> e-mail suspeito entre imediatamente em contato com o DTI.
>
> On 4/20/22 10:54, Leandro Lupori wrote:
> > On 4/18/22 17:22, Cédric Le Goater wrote:
> >
> > > > diff --git a/semihosting/arm-compat-semi.c 
> > > > b/semihosting/arm-compat-semi.c
> > > > index 7a51fd0737..e1279c316c 100644
> > > > --- a/semihosting/arm-compat-semi.c
> > > > +++ b/semihosting/arm-compat-semi.c
> > > > @@ -268,6 +268,31 @@ common_semi_sys_exit_extended(CPUState *cs, int 
> > > > nr)
> > > >
> > > >   #endif
> > > >
> > > > +#ifdef TARGET_PPC64
> > >
> > > This PPC ifdef in an ARM file seems wrong.
> > >
> > > The rest looks OK.
> >
> > IIUC, arm-compat-semi.c is not an ARM specific file, but it's used by 
> > targets that
> > implement ARM-compatible semihosting. It's currently used by ARM and 
> > RISC-V and both use
> > target ifdefs in small parts of this file.
>
> It would be nice to split these out to target/arch/arm-compat-semi.h or 
> something akin.

Ah, ok, I'll try to move the target specific parts to their own header 
files then.

Thanks,
Leandro

> r~