qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.1 04/11] hw/misc: Support NPCM8XX CLK Module Registers


From: Peter Maydell
Subject: Re: [PATCH for-7.1 04/11] hw/misc: Support NPCM8XX CLK Module Registers
Date: Thu, 21 Apr 2022 11:54:37 +0100

On Tue, 5 Apr 2022 at 23:38, Hao Wu <wuhaotsh@google.com> wrote:
>
> NPCM8XX adds a few new registers and have a different set of reset
> values to the CLK modules. This patch supports them.
>
> This patch doesn't support the new clock values generated by these
> registers. Currently no modules use these new clock values so they
> are not necessary at this point.
> Implementation of these clocks might be required when implementing
> these modules.
>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Titus Rwantare<titusr@google.com>

Can you split this one up as well, please ? In particular keep
the purely-mechanical changes (eg renaming structs) separate from
actually-interesting ones.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]