[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 04/64] linux-user/nios2: Adjust error return
From: |
Richard Henderson |
Subject: |
[PATCH v7 04/64] linux-user/nios2: Adjust error return |
Date: |
Thu, 21 Apr 2022 08:16:35 -0700 |
Follow the kernel assembly, which considers all negative
return values to be errors.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/nios2/cpu_loop.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
index 91737c568f..63afba5862 100644
--- a/linux-user/nios2/cpu_loop.c
+++ b/linux-user/nios2/cpu_loop.c
@@ -55,9 +55,14 @@ void cpu_loop(CPUNios2State *env)
env->regs[7], env->regs[8], env->regs[9],
0, 0);
+ /*
+ * See the code after translate_rc_and_ret: all negative
+ * values are errors (aided by userspace restricted to 2G),
+ * errno is returned positive in r2, and error indication
+ * is a boolean in r7.
+ */
env->regs[2] = abs(ret);
- /* Return value is 0..4096 */
- env->regs[7] = ret > 0xfffff000u;
+ env->regs[7] = ret < 0;
break;
case 1:
--
2.34.1
- [PATCH v7 00/64] nios2 fixes, cleanups, shadow reg sets, Richard Henderson, 2022/04/21
- [PATCH v7 02/64] linux-user/nios2: Fix clone child return, Richard Henderson, 2022/04/21
- [PATCH v7 03/64] linux-user/nios2: Drop syscall 0 "workaround", Richard Henderson, 2022/04/21
- [PATCH v7 04/64] linux-user/nios2: Adjust error return,
Richard Henderson <=
- [PATCH v7 01/64] linux-user/nios2: Hoist pc advance to the top of EXCP_TRAP, Richard Henderson, 2022/04/21
- [PATCH v7 05/64] linux-user/nios2: Handle special qemu syscall return values, Richard Henderson, 2022/04/21
- [PATCH v7 06/64] linux-user/nios2: Remove do_sigreturn, Richard Henderson, 2022/04/21
- [PATCH v7 07/64] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn, Richard Henderson, 2022/04/21
- [PATCH v7 09/64] target/nios2: Remove user-only nios2_cpu_do_interrupt, Richard Henderson, 2022/04/21
- [PATCH v7 08/64] tests/tcg/nios2: Re-enable linux-user tests, Richard Henderson, 2022/04/21
- [PATCH v7 10/64] target/nios2: Remove nios2_cpu_record_sigsegv, Richard Henderson, 2022/04/21
- [PATCH v7 11/64] target/nios2: Build helper.c for system only, Richard Henderson, 2022/04/21