[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 25/64] target/nios2: Use hw/registerfields.h for CR_EXCEPTION
From: |
Richard Henderson |
Subject: |
[PATCH v7 25/64] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields |
Date: |
Thu, 21 Apr 2022 08:16:56 -0700 |
Use FIELD_DP32 instead of manual shifting and masking.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/nios2/cpu.h | 4 ++++
target/nios2/helper.c | 37 ++++++++++++++++++++++---------------
2 files changed, 26 insertions(+), 15 deletions(-)
diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h
index 44fc681c58..114b494294 100644
--- a/target/nios2/cpu.h
+++ b/target/nios2/cpu.h
@@ -105,6 +105,10 @@ FIELD(CR_STATUS, RSIE, 23, 1)
#define CR_CPUID 5
#define CR_CTL6 6
#define CR_EXCEPTION 7
+
+FIELD(CR_EXCEPTION, CAUSE, 2, 5)
+FIELD(CR_EXCEPTION, ECCFTL, 31, 1)
+
#define CR_PTEADDR 8
#define CR_PTEADDR_PTBASE_SHIFT 22
#define CR_PTEADDR_PTBASE_MASK (0x3FF << CR_PTEADDR_PTBASE_SHIFT)
diff --git a/target/nios2/helper.c b/target/nios2/helper.c
index 2e5f5b8b54..b30740824c 100644
--- a/target/nios2/helper.c
+++ b/target/nios2/helper.c
@@ -44,8 +44,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_IH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
env->regs[R_EA] = env->pc + 4;
env->pc = cpu->exception_addr;
@@ -63,8 +64,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_EH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
env->ctrl[CR_TLBMISC] &= ~CR_TLBMISC_DBL;
env->ctrl[CR_TLBMISC] |= CR_TLBMISC_WR;
@@ -78,8 +80,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_EH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
env->ctrl[CR_TLBMISC] |= CR_TLBMISC_DBL;
@@ -96,8 +99,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_EH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
if ((env->ctrl[CR_STATUS] & CR_STATUS_EH) == 0) {
env->ctrl[CR_TLBMISC] |= CR_TLBMISC_WR;
@@ -120,8 +124,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_EH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
env->pc = cpu->exception_addr;
break;
@@ -138,8 +143,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_EH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
env->pc = cpu->exception_addr;
break;
@@ -163,8 +169,9 @@ void nios2_cpu_do_interrupt(CPUState *cs)
env->ctrl[CR_STATUS] |= CR_STATUS_EH;
env->ctrl[CR_STATUS] &= ~(CR_STATUS_PIE | CR_STATUS_U);
- env->ctrl[CR_EXCEPTION] &= ~(0x1F << 2);
- env->ctrl[CR_EXCEPTION] |= (cs->exception_index & 0x1F) << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
+ CR_EXCEPTION, CAUSE,
+ cs->exception_index);
env->pc = cpu->exception_addr;
break;
@@ -208,7 +215,7 @@ void nios2_cpu_do_unaligned_access(CPUState *cs, vaddr addr,
CPUNios2State *env = &cpu->env;
env->ctrl[CR_BADADDR] = addr;
- env->ctrl[CR_EXCEPTION] = EXCP_UNALIGN << 2;
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(0, CR_EXCEPTION, CAUSE, EXCP_UNALIGN);
helper_raise_exception(env, EXCP_UNALIGN);
}
--
2.34.1
- [PATCH v7 14/64] target/nios2: Stop generating code if gen_check_supervisor fails, (continued)
- [PATCH v7 14/64] target/nios2: Stop generating code if gen_check_supervisor fails, Richard Henderson, 2022/04/21
- [PATCH v7 15/64] target/nios2: Add NUM_GP_REGS and NUM_CP_REGS, Richard Henderson, 2022/04/21
- [PATCH v7 16/64] target/nios2: Split PC out of env->regs[], Richard Henderson, 2022/04/21
- [PATCH v7 17/64] target/nios2: Split out helper for eret instruction, Richard Henderson, 2022/04/21
- [PATCH v7 18/64] target/nios2: Fix BRET instruction, Richard Henderson, 2022/04/21
- [PATCH v7 19/64] target/nios2: Do not create TCGv for control registers, Richard Henderson, 2022/04/21
- [PATCH v7 20/64] linux-user/nios2: Only initialize SP and PC in target_cpu_copy_regs, Richard Henderson, 2022/04/21
- [PATCH v7 23/64] target/nios2: Clean up nios2_cpu_dump_state, Richard Henderson, 2022/04/21
- [PATCH v7 22/64] target/nios2: Split control registers away from general registers, Richard Henderson, 2022/04/21
- [PATCH v7 24/64] target/nios2: Use hw/registerfields.h for CR_STATUS fields, Richard Henderson, 2022/04/21
- [PATCH v7 25/64] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields,
Richard Henderson <=
- [PATCH v7 21/64] target/nios2: Remove cpu_interrupts_enabled, Richard Henderson, 2022/04/21
- [PATCH v7 26/64] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields, Richard Henderson, 2022/04/21
- [PATCH v7 27/64] target/nios2: Use hw/registerfields.h for CR_TLBACC fields, Richard Henderson, 2022/04/21
- [PATCH v7 28/64] target/nios2: Rename CR_TLBMISC_WR to CR_TLBMISC_WE, Richard Henderson, 2022/04/21
- [PATCH v7 29/64] target/nios2: Use hw/registerfields.h for CR_TLBMISC fields, Richard Henderson, 2022/04/21
- [PATCH v7 30/64] target/nios2: Move R_FOO and CR_BAR into enumerations, Richard Henderson, 2022/04/21
- [PATCH v7 31/64] target/nios2: Create EXCP_SEMIHOST for semi-hosting, Richard Henderson, 2022/04/21
- [PATCH v7 32/64] target/nios2: Clean up nios2_cpu_do_interrupt, Richard Henderson, 2022/04/21
- [PATCH v7 33/64] target/nios2: Hoist CPU_LOG_INT logging, Richard Henderson, 2022/04/21
- [PATCH v7 35/64] target/nios2: Cleanup set of CR_EXCEPTION for do_interrupt, Richard Henderson, 2022/04/21