[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 35/64] target/nios2: Cleanup set of CR_EXCEPTION for do_interr
From: |
Richard Henderson |
Subject: |
[PATCH v7 35/64] target/nios2: Cleanup set of CR_EXCEPTION for do_interrupt |
Date: |
Thu, 21 Apr 2022 08:17:06 -0700 |
The register is entirely read-only for software, and we do not
implement ECC, so we need not deposit the cause into an existing
value; just create a new value from scratch.
Furthermore, exception.CAUSE is not written for break exceptions.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/nios2/helper.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/target/nios2/helper.c b/target/nios2/helper.c
index 25a89724d0..3d9869453b 100644
--- a/target/nios2/helper.c
+++ b/target/nios2/helper.c
@@ -54,9 +54,10 @@ static void do_exception(Nios2CPU *cpu, uint32_t
exception_addr, bool is_break)
new_status &= ~(CR_STATUS_PIE | CR_STATUS_U);
env->ctrl[CR_STATUS] = new_status;
- env->ctrl[CR_EXCEPTION] = FIELD_DP32(env->ctrl[CR_EXCEPTION],
- CR_EXCEPTION, CAUSE,
- cs->exception_index);
+ if (!is_break) {
+ env->ctrl[CR_EXCEPTION] = FIELD_DP32(0, CR_EXCEPTION, CAUSE,
+ cs->exception_index);
+ }
env->pc = exception_addr;
}
--
2.34.1
- [PATCH v7 25/64] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields, (continued)
- [PATCH v7 25/64] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields, Richard Henderson, 2022/04/21
- [PATCH v7 21/64] target/nios2: Remove cpu_interrupts_enabled, Richard Henderson, 2022/04/21
- [PATCH v7 26/64] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields, Richard Henderson, 2022/04/21
- [PATCH v7 27/64] target/nios2: Use hw/registerfields.h for CR_TLBACC fields, Richard Henderson, 2022/04/21
- [PATCH v7 28/64] target/nios2: Rename CR_TLBMISC_WR to CR_TLBMISC_WE, Richard Henderson, 2022/04/21
- [PATCH v7 29/64] target/nios2: Use hw/registerfields.h for CR_TLBMISC fields, Richard Henderson, 2022/04/21
- [PATCH v7 30/64] target/nios2: Move R_FOO and CR_BAR into enumerations, Richard Henderson, 2022/04/21
- [PATCH v7 31/64] target/nios2: Create EXCP_SEMIHOST for semi-hosting, Richard Henderson, 2022/04/21
- [PATCH v7 32/64] target/nios2: Clean up nios2_cpu_do_interrupt, Richard Henderson, 2022/04/21
- [PATCH v7 33/64] target/nios2: Hoist CPU_LOG_INT logging, Richard Henderson, 2022/04/21
- [PATCH v7 35/64] target/nios2: Cleanup set of CR_EXCEPTION for do_interrupt,
Richard Henderson <=
- [PATCH v7 34/64] target/nios2: Handle EXCP_UNALIGN and EXCP_UALIGND, Richard Henderson, 2022/04/21
- [PATCH v7 36/64] target/nios2: Clean up handling of tlbmisc in do_exception, Richard Henderson, 2022/04/21
- [PATCH v7 37/64] target/nios2: Prevent writes to read-only or reserved control fields, Richard Henderson, 2022/04/21
- [PATCH v7 38/64] target/nios2: Implement cpuid, Richard Henderson, 2022/04/21
- [PATCH v7 39/64] target/nios2: Implement CR_STATUS.RSIE, Richard Henderson, 2022/04/21
- [PATCH v7 42/64] target/nios2: Use tcg_constant_tl, Richard Henderson, 2022/04/21
- [PATCH v7 41/64] target/nios2: Support division error exception, Richard Henderson, 2022/04/21
- [PATCH v7 44/64] target/nios2: Split out helpers for gen_* translate macros, Richard Henderson, 2022/04/21