[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS
From: |
Greg Kurz |
Subject: |
Re: [PATCH v2 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS |
Date: |
Thu, 21 Apr 2022 18:32:02 +0200 |
On Thu, 21 Apr 2022 17:07:38 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> mknod() on macOS does not support creating regular files, so
> divert to openat_file() if S_IFREG is passed with mode argument.
>
> Furthermore, 'man 2 mknodat' on Linux says: "Zero file type is
> equivalent to type S_IFREG".
>
> Link: https://lore.kernel.org/qemu-devel/17933734.zYzKuhC07K@silver/
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> Reviewed-by: Will Cohen <wwcohen@gmail.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> hw/9pfs/9p-util-darwin.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/9pfs/9p-util-darwin.c b/hw/9pfs/9p-util-darwin.c
> index bec0253474..e24d09763a 100644
> --- a/hw/9pfs/9p-util-darwin.c
> +++ b/hw/9pfs/9p-util-darwin.c
> @@ -77,6 +77,15 @@ int fsetxattrat_nofollow(int dirfd, const char *filename,
> const char *name,
> int qemu_mknodat(int dirfd, const char *filename, mode_t mode, dev_t dev)
> {
> int preserved_errno, err;
> +
> + if (S_ISREG(mode) || !(mode & S_IFMT)) {
> + int fd = openat_file(dirfd, filename, O_CREAT, mode);
> + if (fd == -1) {
> + return fd;
> + }
> + close(fd);
> + return 0;
> + }
> if (!pthread_fchdir_np) {
> error_report_once("pthread_fchdir_np() not available on this version
> of macOS");
> return -ENOTSUP;
- [PATCH v2 0/5] 9pfs: macOS host fixes, Christian Schoenebeck, 2022/04/21
- [PATCH v2 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS, Christian Schoenebeck, 2022/04/21
- Re: [PATCH v2 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS,
Greg Kurz <=
- [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Christian Schoenebeck, 2022/04/21
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Greg Kurz, 2022/04/21
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Akihiko Odaki, 2022/04/21
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Christian Schoenebeck, 2022/04/22
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Akihiko Odaki, 2022/04/23
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Christian Schoenebeck, 2022/04/24
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Akihiko Odaki, 2022/04/25
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Greg Kurz, 2022/04/26
- Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Akihiko Odaki, 2022/04/26