qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c


From: Peter Maydell
Subject: Re: [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c
Date: Thu, 21 Apr 2022 19:49:12 +0100

On Sun, 17 Apr 2022 at 18:59, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use tcg_constant_{i32,i64,ptr} as appropriate throughout, which
> means we get to remove lots of tcg_temp_free_*.  Drop variables
> in many cases, passing the constant directly to another function.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/translate-a64.c | 302 +++++++++++--------------------------
>  1 file changed, 90 insertions(+), 212 deletions(-)

Split this one up a bit, please. It's not too hard to review because
all the changes are local, but if we find there's a regression
in here later I don't really want to have to wade through a 300 line
diff to find it...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]