[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 20/50] dino: use numerical constant for iar0 and iar1 reset value
From: |
Mark Cave-Ayland |
Subject: |
[PATCH 20/50] dino: use numerical constant for iar0 and iar1 reset values |
Date: |
Thu, 21 Apr 2022 20:30:30 +0100 |
This is to allow us to decouple the DINO device from the board logic. The choice
of using a hard-coded constant (along with a comment) is to match how this is
already done for toc_addr. If it is decided later that these values need to be
configurable then they can easily be converted to qdev properties.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/hppa/dino.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index 6d12c385aa..aa7f812e22 100644
--- a/hw/hppa/dino.c
+++ b/hw/hppa/dino.c
@@ -403,7 +403,7 @@ static void dino_pcihost_reset(DeviceState *dev)
{
DinoState *s = DINO_PCI_HOST_BRIDGE(dev);
- s->iar0 = s->iar1 = CPU_HPA + 3;
+ s->iar0 = s->iar1 = 0xFFFB0000 + 3; /* CPU_HPA + 3 */
s->toc_addr = 0xFFFA0030; /* IO_COMMAND of CPU */
}
--
2.20.1
- [PATCH 10/50] dino: return PCIBus from dino_init() using qdev_get_child_bus(), (continued)
- [PATCH 10/50] dino: return PCIBus from dino_init() using qdev_get_child_bus(), Mark Cave-Ayland, 2022/04/21
- [PATCH 08/50] dino: move initial register configuration to new dino_pcihost_reset() function, Mark Cave-Ayland, 2022/04/21
- [PATCH 06/50] dino: move pci_setup_iommu() to dino_pcihost_init(), Mark Cave-Ayland, 2022/04/21
- [PATCH 05/50] dino: add memory-as property containing a link to the memory address space, Mark Cave-Ayland, 2022/04/21
- [PATCH 11/50] dino: split declarations from dino.c into dino.h, Mark Cave-Ayland, 2022/04/21
- [PATCH 18/50] dino: remove unused dino_set_timer_irq() IRQ handler, Mark Cave-Ayland, 2022/04/21
- [PATCH 13/50] dino: change dino_init() to return the DINO device instead of PCIBus, Mark Cave-Ayland, 2022/04/21
- [PATCH 12/50] hppa: use new CONFIG_HPPA_GENERIC option instead of CONFIG_DINO to build hppa machine, Mark Cave-Ayland, 2022/04/21
- [PATCH 15/50] dino.h: add defines for DINO IRQ numbers, Mark Cave-Ayland, 2022/04/21
- [PATCH 17/50] dino: wire up serial IRQ using a qdev GPIO in machine.c, Mark Cave-Ayland, 2022/04/21
- [PATCH 20/50] dino: use numerical constant for iar0 and iar1 reset values,
Mark Cave-Ayland <=
- [PATCH 16/50] dino: define IRQ inputs as qdev GPIOs, Mark Cave-Ayland, 2022/04/21
- [PATCH 19/50] hppa: move dino_init() from dino.c to machine.c, Mark Cave-Ayland, 2022/04/21
- [PATCH 14/50] machine.c: map DINO device during board configuration, Mark Cave-Ayland, 2022/04/21
- [PATCH 21/50] dino: move DINO HPA constants from hppa_hardware.h to dino.h, Mark Cave-Ayland, 2022/04/21
- [PATCH 24/50] lasi: move memory region initialisation to new lasi_init() function, Mark Cave-Ayland, 2022/04/21
- [PATCH 26/50] lasi: move initialisation of iar and rtc to new lasi_reset() function, Mark Cave-Ayland, 2022/04/21
- [PATCH 27/50] lasi: move LASIState and associated QOM structures to lasi.h, Mark Cave-Ayland, 2022/04/21
- [PATCH 23/50] lasi: checkpatch fixes, Mark Cave-Ayland, 2022/04/21
- [PATCH 22/50] dino: move from hw/hppa to hw/pci-host, Mark Cave-Ayland, 2022/04/21
- [PATCH 25/50] lasi: move register memory mapping from lasi.c to machine.c, Mark Cave-Ayland, 2022/04/21