[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v5 02/23] vdpa: Fix bad index calculus at vhost_vdpa_get_
From: |
Eugenio Perez Martin |
Subject: |
Re: [RFC PATCH v5 02/23] vdpa: Fix bad index calculus at vhost_vdpa_get_vring_base |
Date: |
Fri, 22 Apr 2022 11:00:53 +0200 |
On Thu, Apr 14, 2022 at 5:34 AM Jason Wang <jasowang@redhat.com> wrote:
>
>
> 在 2022/4/8 21:33, Eugenio Pérez 写道:
> > Fixes: 6d0b222666 ("vdpa: Adapt vhost_vdpa_get_vring_base to SVQ")
> >
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > ---
>
>
> Acked-by: Jason Wang <jasowang@redhat.com>
>
> I think we need to use a separate patch for this.
>
Do you mean I should send this patch in a separate series? I can batch
all the fixes for SVQ.
>
> > hw/virtio/vhost-vdpa.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> > index 9e5fe15d03..1f229ff4cb 100644
> > --- a/hw/virtio/vhost-vdpa.c
> > +++ b/hw/virtio/vhost-vdpa.c
> > @@ -1172,11 +1172,11 @@ static int vhost_vdpa_get_vring_base(struct
> > vhost_dev *dev,
> > struct vhost_vring_state *ring)
> > {
> > struct vhost_vdpa *v = dev->opaque;
> > + int vdpa_idx = ring->index - dev->vq_index;
> > int ret;
> >
> > if (v->shadow_vqs_enabled) {
> > - VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs,
> > - ring->index);
> > + VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs,
> > vdpa_idx);
> >
> > /*
> > * Setting base as last used idx, so destination will see as
> > available
>
- [RFC PATCH v5 00/23] Net Control VQ support with asid in vDPA SVQ, Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 01/23] vdpa: Add missing tracing to batch mapping functions, Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 02/23] vdpa: Fix bad index calculus at vhost_vdpa_get_vring_base, Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 03/23] util: Return void on iova_tree_remove, Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 04/23] hw/virtio: Replace g_memdup() by g_memdup2(), Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 05/23] vhost: Fix bad return of descriptors to SVQ, Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 06/23] vdpa: Add x-svq to NetdevVhostVDPAOptions, Eugenio Pérez, 2022/04/08
- [RFC PATCH v5 07/23] vhost: move descriptor translation to vhost_svq_vring_write_descs, Eugenio Pérez, 2022/04/08