[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 29/60] target/arm: Change cpreg access permissions to enum
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 29/60] target/arm: Change cpreg access permissions to enum |
Date: |
Fri, 22 Apr 2022 10:52:21 +0100 |
On Sun, 17 Apr 2022 at 19:15, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Create a typedef as well, and use it in ARMCPRegInfo.
> This won't be perfect for debugging, but it'll nicely
> display the most common cases.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> @@ -8741,8 +8741,7 @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
> break;
> default:
> /* broken reginfo with out-of-range opc1 */
> - assert(false);
> - break;
> + g_assert_not_reached();
> }
> /* assert our permissions are not too lax (stricter is fine) */
> assert((r->access & ~mask) == 0);
This part is an unrelated change and should be a separate patch.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v3 26/60] target/arm: Replace sentinels with ARRAY_SIZE in cpregs.h, (continued)
- [PATCH v3 27/60] target/arm: Make some more cpreg data static const, Richard Henderson, 2022/04/17
- [PATCH v3 24/60] target/arm: Split out cpregs.h, Richard Henderson, 2022/04/17
- [PATCH v3 28/60] target/arm: Reorg ARMCPRegInfo type field bits, Richard Henderson, 2022/04/17
- [PATCH v3 30/60] target/arm: Name CPState type, Richard Henderson, 2022/04/17
- [PATCH v3 29/60] target/arm: Change cpreg access permissions to enum, Richard Henderson, 2022/04/17
- Re: [PATCH v3 29/60] target/arm: Change cpreg access permissions to enum,
Peter Maydell <=
- [PATCH v3 37/60] target/arm: Merge zcr reginfo, Richard Henderson, 2022/04/17
- [PATCH v3 31/60] target/arm: Name CPSecureState type, Richard Henderson, 2022/04/17
- [PATCH v3 38/60] target/arm: Add isar predicates for FEAT_Debugv8p2, Richard Henderson, 2022/04/17
- [PATCH v3 39/60] target/arm: Adjust definition of CONTEXTIDR_EL2, Richard Henderson, 2022/04/17
- [PATCH v3 33/60] target/arm: Store cpregs key in the hash table directly, Richard Henderson, 2022/04/17
- [PATCH v3 36/60] target/arm: Drop EL3 no EL2 fallbacks, Richard Henderson, 2022/04/17
- [PATCH v3 34/60] target/arm: Cleanup add_cpreg_to_hashtable, Richard Henderson, 2022/04/17