[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 64/64] tests/tcg/nios2: Add test-shadow-1
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v7 64/64] tests/tcg/nios2: Add test-shadow-1 |
|
Date: |
Fri, 22 Apr 2022 14:26:11 +0100 |
On Thu, 21 Apr 2022 at 17:13, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Add a regression test for tcg indirect global lowering.
>
> This appeared with nios2, with cps != 0, so that we use
> indirection into the shadow register set. An indirect
> call verifies alignment of rA. The use of rA was live
> across the brcond leading to a tcg_debug_assert failure.
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> +/*
> + * Regresion test for TCG indirect global lowering.
"Regression".
Also, file is missing copyright/license header comment.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v7 49/64] target/nios2: Hoist set of is_jmp into gen_goto_tb, (continued)
- [PATCH v7 49/64] target/nios2: Hoist set of is_jmp into gen_goto_tb, Richard Henderson, 2022/04/21
- [PATCH v7 50/64] target/nios2: Use gen_goto_tb for DISAS_TOO_MANY, Richard Henderson, 2022/04/21
- [PATCH v7 52/64] target/nios2: Implement Misaligned destination exception, Richard Henderson, 2022/04/21
- [PATCH v7 58/64] linux-user/nios2: Handle various SIGILL exceptions, Richard Henderson, 2022/04/21
- [PATCH v7 61/64] hw/nios2: Move memory regions into Nios2Machine, Richard Henderson, 2022/04/21
- [PATCH v7 56/64] target/nios2: Implement EIC interrupt processing, Richard Henderson, 2022/04/21
- [PATCH v7 55/64] target/nios2: Update helper_eret for shadow registers, Richard Henderson, 2022/04/21
- [PATCH v7 59/64] hw/intc: Vectored Interrupt Controller (VIC), Richard Henderson, 2022/04/21
- [PATCH v7 64/64] tests/tcg/nios2: Add test-shadow-1, Richard Henderson, 2022/04/21
- Re: [PATCH v7 64/64] tests/tcg/nios2: Add test-shadow-1,
Peter Maydell <=
- [PATCH v7 53/64] target/nios2: Introduce shadow register sets, Richard Henderson, 2022/04/21
- [PATCH v7 60/64] hw/nios2: Introduce Nios2MachineState, Richard Henderson, 2022/04/21
- [PATCH v7 54/64] target/nios2: Implement rdprs, wrprs, Richard Henderson, 2022/04/21
- [PATCH v7 57/64] target/nios2: Advance pc when raising exceptions, Richard Henderson, 2022/04/21
- [PATCH v7 62/64] hw/nios2: Machine with a Vectored Interrupt Controller, Richard Henderson, 2022/04/21
- [PATCH v7 63/64] tests/tcg/nios2: Add semihosting multiarch tests, Richard Henderson, 2022/04/21