[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/60] target/arm: Change DisasContext.thumb to bool
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 08/60] target/arm: Change DisasContext.thumb to bool |
Date: |
Fri, 22 Apr 2022 15:04:00 +0100 |
On Fri, 22 Apr 2022 at 15:01, Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > Bool is a more appropriate type for this value.
> > Move the member down in the struct to keep the
> > bool type members together and remove a hole.
>
> Does gcc even attempt to pack bools? Aren't they basically int types?
It's impdef, I think, but it'll typically be a 1 byte integer
rather than a 4 byte integer, with the usual struct packing
rules for 1 byte type sizes.
-- PMM
- Re: [PATCH v3 05/60] target/arm: Change DisasContext.aarch64 to bool, (continued)
- [PATCH v3 11/60] target/arm: Split out set_btype_raw, Richard Henderson, 2022/04/17
- [PATCH v3 17/60] target/arm: Use tcg_constant in translate.c, Richard Henderson, 2022/04/17
- [PATCH v3 20/60] target/arm: Use smin/smax for do_sat_addsub_32, Richard Henderson, 2022/04/17
- [PATCH v3 12/60] target/arm: Split out gen_rebuild_hflags, Richard Henderson, 2022/04/17
- [PATCH v3 16/60] target/arm: Simplify aa32 DISAS_WFI, Richard Henderson, 2022/04/17