Re: [PATCH v3 7/7] target/xtensa: use tcg_constant_* for remaining opcodes

[Richard Henderson]

On 4/22/22 04:50, Max Filippov wrote:
> - gen_jumpi passes target PC to the helper;
> - gen_callw_slot uses callinc (1..3);
> - gen_brcondi passes immediate field (less than 32 different possible
>    values) to the helper;
> - disas_xtensa_insn passes PC to the helpers;
> - translate_entry passes PC, stack register number (0..15) and stack
>    frame size to the helper;
> - gen_check_exclusive passes PC and boolean flag to the helper;
> - test_exceptions_retw passes PC to the helper;
> - gen_check_atomctl passes PC to the helper;
> - translate_ssai passes immediate shift amount (0..31) to the helper;
> - gen_waiti passes next PC and an immediate (0..15) to the helper;
>
> use tcg_constant_* for the constants listed above. Fold gen_waiti body
> into the translate_waiti as it's the only user.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> ---
> Changes v2->v3:
> - use 'pc' consistently in gen_check_atomctl
>
> Changes v1->v2:
> - convert gen_jumpi, disas_xtensa_insn, test_exceptions_retw and
>    gen_check_atomctl
> - use tcg_constant_* for PC
>
>   target/xtensa/translate.c | 77 +++++++++++++--------------------------
>   1 file changed, 25 insertions(+), 52 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~