Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is created

[Gautam Agrawal]

I will make changes in hw/ppc/spapr.c . In hw/hppa/machine.c ,
vga_interface_type is used inside if condition to check for graphics
device creation, but I am not able to find any relation with creation
of vga interface. Could you kindly provide some pointers about it?

thanks,

Regards,
Gautam Agrawal

On Thu, 21 Apr 2022 at 20:59, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Wed, 13 Apr 2022 at 18:23, Gautam Agrawal <gautamnagrawal@gmail.com> wrote:
> >
> > A global boolean variable "vga_interface_created"(declared in 
> > softmmu/globals.c)
> > has been used to track the creation of vga interface. If the vga flag is 
> > passed
> > in the command line "default_vga"(declared in softmmu/vl.c) variable is set 
> > to 0.
> > To warn user, the condition checks if vga_interface_created is false
> > and default_vga is equal to 0.If "-vga none" is passed, this patch will not 
> > warn the
> > user regarding the creation of VGA device.
> >
> > The initialisation of Global variable "vga_interface_created" in 
> > softmmu/globals.c
> > has also been corrected.
> >
> > The warning "A -vga option was passed but this
> > machine type does not use that option; no VGA device has been created"
> > is logged if vga flag is passed but no vga device is created.
> >
> > "vga_interface_created" has also been included in "xen_machine_pv.c" and
> > "fuloong2e.c". This patch has been tested for x86_64, i386, sparc, sparc64 
> > and arm boards.
> >
> > Signed-off-by: Gautam Agrawal <gautamnagrawal@gmail.com>
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/581
> > ---
> >  hw/isa/isa-bus.c          | 1 +
> >  hw/mips/fuloong2e.c       | 1 +
> >  hw/pci/pci.c              | 1 +
> >  hw/sparc/sun4m.c          | 2 ++
> >  hw/sparc64/sun4u.c        | 1 +
> >  hw/xenpv/xen_machine_pv.c | 1 +
> >  include/sysemu/sysemu.h   | 1 +
> >  softmmu/globals.c         | 1 +
> >  softmmu/vl.c              | 6 ++++++
> >  9 files changed, 15 insertions(+)
>
> You've missed the uses of vga_interface_type in hw/hppa/machine.c
> and hw/ppc/spapr.c. ("git grep vga_interface_type" will give you the
> list of all the files which touch that variable.)
>
> thanks
> -- PMM