[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 28/34] configure: simplify vhost-net-{user, vdpa} configuratio
From: |
Paolo Bonzini |
Subject: |
[PATCH v2 28/34] configure: simplify vhost-net-{user, vdpa} configuration |
Date: |
Sat, 23 Apr 2022 14:51:45 +0200 |
Cleanup to ease review of the conversion to meson. vhost_net_user and
vhost_net_vdpa are never assigned anything in the command line parsing
loop, so they are always equal to $vhost_user and $vhost_vdpa.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/configure b/configure
index 19947d8d6c..c5bffcf703 100755
--- a/configure
+++ b/configure
@@ -1554,10 +1554,6 @@ if test "$vhost_vsock" = "yes" && test "$vhost_kernel"
!= "yes"; then
fi
# vhost-user backends
-test "$vhost_net_user" = "" && vhost_net_user=$vhost_user
-if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then
- error_exit "--enable-vhost-net-user requires --enable-vhost-user"
-fi
test "$vhost_crypto" = "" && vhost_crypto=$vhost_user
if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then
error_exit "--enable-vhost-crypto requires --enable-vhost-user"
@@ -1566,16 +1562,11 @@ test "$vhost_user_fs" = "" && vhost_user_fs=$vhost_user
if test "$vhost_user_fs" = "yes" && test "$vhost_user" = "no"; then
error_exit "--enable-vhost-user-fs requires --enable-vhost-user"
fi
-#vhost-vdpa backends
-test "$vhost_net_vdpa" = "" && vhost_net_vdpa=$vhost_vdpa
-if test "$vhost_net_vdpa" = "yes" && test "$vhost_vdpa" = "no"; then
- error_exit "--enable-vhost-net-vdpa requires --enable-vhost-vdpa"
-fi
# OR the vhost-kernel, vhost-vdpa and vhost-user values for simplicity
if test "$vhost_net" = ""; then
- test "$vhost_net_user" = "yes" && vhost_net=yes
- test "$vhost_net_vdpa" = "yes" && vhost_net=yes
+ test "$vhost_user" = "yes" && vhost_net=yes
+ test "$vhost_vdpa" = "yes" && vhost_net=yes
test "$vhost_kernel" = "yes" && vhost_net=yes
fi
@@ -2104,10 +2095,10 @@ fi
if test "$vhost_net" = "yes" ; then
echo "CONFIG_VHOST_NET=y" >> $config_host_mak
fi
-if test "$vhost_net_user" = "yes" ; then
+if test "$vhost_user" = "yes" ; then
echo "CONFIG_VHOST_NET_USER=y" >> $config_host_mak
fi
-if test "$vhost_net_vdpa" = "yes" ; then
+if test "$vhost_vdpa" = "yes" ; then
echo "CONFIG_VHOST_NET_VDPA=y" >> $config_host_mak
fi
if test "$vhost_crypto" = "yes" ; then
--
2.35.1
- [PATCH v2 12/34] meson: remove CONFIG_XEN_PCI_PASSTHROUGH from config-target.h, (continued)
- [PATCH v2 12/34] meson: remove CONFIG_XEN_PCI_PASSTHROUGH from config-target.h, Paolo Bonzini, 2022/04/23
- [PATCH v2 15/34] meson-buildoptions: add support for string options, Paolo Bonzini, 2022/04/23
- [PATCH v2 16/34] configure, meson: move iasl detection to meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 23/34] meson: always combine directories with prefix, Paolo Bonzini, 2022/04/23
- [PATCH v2 24/34] configure: switch directory options to automatic parsing, Paolo Bonzini, 2022/04/23
- [PATCH v2 14/34] meson, configure: move Xen detection to meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 18/34] configure: switch string options to automatic parsing, Paolo Bonzini, 2022/04/23
- [PATCH v2 29/34] build: move vhost-vsock configuration to Kconfig, Paolo Bonzini, 2022/04/23
- [PATCH v2 27/34] meson, virtio: place all virtio-pci devices under virtio_pci_ss, Paolo Bonzini, 2022/04/23
- [PATCH v2 21/34] meson, configure: move --with-pkgversion, CONFIG_STAMP to meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 28/34] configure: simplify vhost-net-{user, vdpa} configuration,
Paolo Bonzini <=
- [PATCH v2 30/34] build: move vhost-scsi configuration to Kconfig, Paolo Bonzini, 2022/04/23
- [PATCH v2 31/34] build: move vhost-user-fs configuration to Kconfig, Paolo Bonzini, 2022/04/23
- [PATCH v2 32/34] meson: create have_vhost_* variables, Paolo Bonzini, 2022/04/23
- [PATCH v2 22/34] meson, configure: move --interp-prefix to meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 34/34] configure, meson: move vhost options to Meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 19/34] meson, configure: move --tls-priority to meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 20/34] meson, configure: move bdrv whitelists to meson, Paolo Bonzini, 2022/04/23
- [PATCH v2 25/34] meson: pass more options directly as -D, Paolo Bonzini, 2022/04/23
- [PATCH v2 26/34] configure: omit options with default values from meson command line, Paolo Bonzini, 2022/04/23
- [PATCH v2 17/34] configure: move Windows flags detection to meson, Paolo Bonzini, 2022/04/23