[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is created |
|
Date: |
Sat, 23 Apr 2022 14:27:16 +0100 |
On Sat, 23 Apr 2022 at 11:00, Gautam Agrawal <gautamnagrawal@gmail.com> wrote:
>
> I will make changes in hw/ppc/spapr.c . In hw/hppa/machine.c ,
> vga_interface_type is used inside if condition to check for graphics
> device creation, but I am not able to find any relation with creation
> of vga interface. Could you kindly provide some pointers about it?
It's exactly the same as all the other places that look
at vga_interface_type -- it looks at it and decides
whether to create a graphics device. (Arguably it should
not really be saying "anything except 'none' means create
the 'artist' graphics device", but that's a separate bug;
all you need to care about is "did we create a graphics
device because the user passed a -vga option".)
-- PMM