[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/18] audio/spiceaudio: Fail initialisation when not using spice
From: |
Martin Kletzander |
Subject: |
[PATCH 18/18] audio/spiceaudio: Fail initialisation when not using spice |
Date: |
Mon, 25 Apr 2022 10:22:01 +0200 |
The caller would already fail, but this way the message can better
express the reason for the failure.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2043498
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
audio/spiceaudio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index a8d370fe6f31..fdbd7dc285ad 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -74,8 +74,9 @@ static const SpiceRecordInterface record_sif = {
static void *spice_audio_init(Audiodev *dev)
{
if (!using_spice) {
- return NULL;
+ error_setg(&error_fatal, "Cannot use spice audio without -spice");
}
+
return &spice_audio_init;
}
--
2.35.1
- [PATCH 12/18] hw/ppc: Support machine-default audiodev with fallback, (continued)
- [PATCH 12/18] hw/ppc: Support machine-default audiodev with fallback, Martin Kletzander, 2022/04/25
- [PATCH 16/18] audio: Remove legacy audio environment variables and options, Martin Kletzander, 2022/04/25
- [PATCH 13/18] audio: Make AUD_register_card fallible and require audiodev=, Martin Kletzander, 2022/04/25
- [PATCH 03/18] hw/audio: Simplify hda audio init, Martin Kletzander, 2022/04/25
- [PATCH 09/18] hw/display/xlnx_dp.c: Add audiodev property, Martin Kletzander, 2022/04/25
- [PATCH 18/18] audio/spiceaudio: Fail initialisation when not using spice,
Martin Kletzander <=
- [PATCH 05/18] tests/qtest: Specify audiodev= and -audiodev, Martin Kletzander, 2022/04/25
- [PATCH 02/18] hw/input/tsc210x: Extract common init code into new function, Martin Kletzander, 2022/04/25
- [PATCH 15/18] audio: Be more strict during audio backend initialisation, Martin Kletzander, 2022/04/25
- Re: [PATCH 00/18] RFC: Remove deprecated audio features, Mark Cave-Ayland, 2022/04/25