Re: [PATCH v3 2/3] hw/audio/ac97: Remove unimplemented reset functions

[Víctor Colombo]

On 23/04/2022 06:36, BALATON Zoltan wrote:
> The warm_reset() and cold_reset() functions are not implemented and do
> nothing so no point in calling them or keep around as dead code.
> Therefore remove them for now.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/audio/ac97.c | 17 +----------------
>   1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
> index 6b1c12bece..6584aa749e 100644
> --- a/hw/audio/ac97.c
> +++ b/hw/audio/ac97.c
> @@ -222,16 +222,6 @@ static void po_callback(void *opaque, int free);
>   static void pi_callback(void *opaque, int avail);
>   static void mc_callback(void *opaque, int avail);
>
> -static void warm_reset(AC97LinkState *s)
> -{
> -    (void)s;
> -}
> -
> -static void cold_reset(AC97LinkState *s)
> -{
> -    (void)s;
> -}
> -
>   static void fetch_bd(AC97LinkState *s, AC97BusMasterRegs *r)
>   {
>       uint8_t b[8];
> @@ -921,12 +911,7 @@ static void nabm_writel(void *opaque, uint32_t addr, 
> uint32_t val)
>           dolog("BDBAR[%d] <- 0x%x (bdbar 0x%x)\n", GET_BM(index), val, 
> r->bdbar);
>           break;
>       case GLOB_CNT:
> -        if (val & GC_WR) {
> -            warm_reset(s);
> -        }
> -        if (val & GC_CR) {
> -            cold_reset(s);
> -        }
> +        /* TODO: Handle WR or CR being set (warm/cold reset requests) */
>           if (!(val & (GC_WR | GC_CR))) {
>               s->glob_cnt = val & GC_VALID_MASK;
>           }
> --
> 2.30.4

Reviewed-by: Víctor Colombo <victor.colombo@eldorado.org.br>