[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/xtensa: import core lx106
From: |
Simon Safar |
Subject: |
Re: [PATCH v2] target/xtensa: import core lx106 |
Date: |
Sun, 24 Apr 2022 22:23:31 -0700 |
User-agent: |
Cyrus-JMAP/3.7.0-alpha0-569-g7622ad95cc-fm-20220421.002-g7622ad95 |
Hi Max,
On Sat, Apr 23, 2022, at 2:41 PM, Max Filippov wrote:
> I've noticed that this file is not from the original overlay (which I happen
> to have here:
> https://github.com/jcmvbkbc/xtensa-toolchain-build/blob/master/overlays/original/lx106.tar.gz),
> but has been changed (by adding '& ~1' to the 7th column), probably
> to make some older gdb version work.
> This change is not needed for the modern gdb versions.
> I've reverted this change and checked that the mainline gdb-11.1
> built with the original overlay for the xtensa-elf target correctly
> interacts with the QEMU. Can you please confirm that?
for simplicity, I just tried re-importing everything with your overlay (vs. the
one from xtensa); both actual code execution & gdb seems to be working nicely.
Yours is also nicer since there is about zero mismatch between what
import-core.sh expects & what it has access to (... while I had to tweak it a
bit, e.g. to skip core-matmap.inc, for it to be satisfied with the xtensa
version).
Should I send a v3 with the results from importing your variant of the overlay?
(although at this point my "contribution" is really just reordering cores.list
after running the script :))
Simon