Re: [PATCH 05/10] libqtest: split QMP part in libqmp

[Thomas Huth]

On 22/04/2022 10.36, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This will help moving QAPI/QMP in a common subproject.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   tests/qtest/libqmp.h           |  50 +++++++
>   tests/qtest/libqtest.h         |  29 +---
>   tests/qtest/libqmp.c           | 233 +++++++++++++++++++++++++++++++++
>   tests/qtest/libqtest.c         | 205 +----------------------------
>   tests/qtest/libqos/meson.build |   5 +-
>   tests/unit/meson.build         |   2 +-
>   6 files changed, 290 insertions(+), 234 deletions(-)
>   create mode 100644 tests/qtest/libqmp.h
>   create mode 100644 tests/qtest/libqmp.c
[...]
> diff --git a/tests/qtest/libqos/meson.build b/tests/qtest/libqos/meson.build
> index e988d1579172..9f292339f9cf 100644
> --- a/tests/qtest/libqos/meson.build
> +++ b/tests/qtest/libqos/meson.build
> @@ -1,4 +1,7 @@
> -libqos_srcs = files('../libqtest.c',
> +libqos_srcs = files(
> +        '../libqtest.c',
> +        '../libqmp.c',

I just realized that we link libqos to each and every qtest, though we 
should only link it against the qos-test :-/

Anyway, that's not related to your patch and we can fix that later, so for 
this patch here:

Acked-by: Thomas Huth <thuth@redhat.com>