[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/8] crypto-akcipher: Introduce akcipher types to qapi
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v4 2/8] crypto-akcipher: Introduce akcipher types to qapi |
Date: |
Tue, 26 Apr 2022 11:34:46 +0100 |
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Mon, Apr 11, 2022 at 06:43:21PM +0800, zhenwei pi wrote:
> From: Lei He <helei.sig11@bytedance.com>
>
> Introduce akcipher types, also include RSA related types.
>
> Signed-off-by: Lei He <helei.sig11@bytedance.com>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> qapi/crypto.json | 64 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
snip
> +##
> +# @QCryptoAkCipherOptions:
> +#
> +# The options that are available for all asymmetric key algorithms
> +# when creating a new QCryptoAkCipher.
> +#
> +# Since: 7.1
> +##
> +{ 'union': 'QCryptoAkCipherOptions',
> + 'base': { 'algorithm': 'QCryptoAkCipherAlgorithm' },
> + 'discriminator': 'algorithm',
> + 'data': { 'rsa': 'QCryptoAkCipherOptionsRSA' }}
I mistakenly suggested 'algorithm' here, but for consistency
with other fields, I should have said just 'alg'.
With that change
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v4 0/8] Introduce akcipher service for virtio-crypto, zhenwei pi, 2022/04/11
- [PATCH v4 1/8] virtio-crypto: header update, zhenwei pi, 2022/04/11
- [PATCH v4 2/8] crypto-akcipher: Introduce akcipher types to qapi, zhenwei pi, 2022/04/11
- Re: [PATCH v4 2/8] crypto-akcipher: Introduce akcipher types to qapi,
Daniel P . Berrangé <=
- [PATCH v4 3/8] crypto: Introduce akcipher crypto class, zhenwei pi, 2022/04/11
- [PATCH v4 4/8] crypto: add ASN.1 decoder, zhenwei pi, 2022/04/11
- [PATCH v4 5/8] crypto: Implement RSA algorithm by hogweed, zhenwei pi, 2022/04/11
- [PATCH v4 6/8] crypto: Implement RSA algorithm by gcrypt, zhenwei pi, 2022/04/11
- [PATCH v4 7/8] tests/crypto: Add test suite for crypto akcipher, zhenwei pi, 2022/04/11