Re: [PULL 2/9] Replacing CONFIG_VNC_PNG with CONFIG_PNG

[Richard Henderson]

On 4/26/22 04:03, Gerd Hoffmann wrote:
> From: Kshitij Suri <kshitij.suri@nutanix.com>
>
> Libpng is only detected if VNC is enabled currently. This patch adds a
> generalised png option in the meson build which is aimed to replace use of
> CONFIG_VNC_PNG with CONFIG_PNG.
>
> Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Message-Id: <20220408071336.99839-2-kshitij.suri@nutanix.com>
>
> [ kraxel: add meson-buildoptions.sh updates ]
> [ kraxel: fix centos8 testcase ]
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   meson_options.txt                              |  4 ++--
>   ui/vnc.h                                       |  2 +-
>   ui/vnc-enc-tight.c                             | 18 +++++++++---------
>   ui/vnc.c                                       |  4 ++--
>   meson.build                                    | 12 +++++++-----
>   .../ci/org.centos/stream/8/x86_64/configure    |  2 +-
>   scripts/meson-buildoptions.sh                  |  6 +++---
>   7 files changed, 25 insertions(+), 23 deletions(-)

There are still two references to --enable-vnc-png:

$ git grep enable-vnc-png

scripts/ci/org.centos/stream/8/x86_64/configure:--enable-vnc-png \

scripts/coverity-scan/run-coverity-scan:    --enable-vnc --enable-vnc-sasl 
--enable-vnc-jpeg --enable-vnc-png \


r~