[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/6] softfloat: Use FloatRelation within partsN_compare
From: |
Richard Henderson |
Subject: |
[PULL 5/6] softfloat: Use FloatRelation within partsN_compare |
Date: |
Tue, 26 Apr 2022 21:39:41 -0700 |
As the return type is FloatRelation, it's clearer to
use the type for 'cmp' within the function.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220401132240.79730-3-richard.henderson@linaro.org>
---
fpu/softfloat-parts.c.inc | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc
index db3e1f393d..bbeadaa189 100644
--- a/fpu/softfloat-parts.c.inc
+++ b/fpu/softfloat-parts.c.inc
@@ -1327,16 +1327,19 @@ static FloatRelation partsN(compare)(FloatPartsN *a,
FloatPartsN *b,
float_status *s, bool is_quiet)
{
int ab_mask = float_cmask(a->cls) | float_cmask(b->cls);
- int cmp;
if (likely(ab_mask == float_cmask_normal)) {
+ FloatRelation cmp;
+
if (a->sign != b->sign) {
goto a_sign;
}
- if (a->exp != b->exp) {
- cmp = a->exp < b->exp ? -1 : 1;
- } else {
+ if (a->exp == b->exp) {
cmp = frac_cmp(a, b);
+ } else if (a->exp < b->exp) {
+ cmp = float_relation_less;
+ } else {
+ cmp = float_relation_greater;
}
if (a->sign) {
cmp = -cmp;
--
2.34.1
- [PULL 0/6] Coverity patch queue, Richard Henderson, 2022/04/27
- [PULL 3/6] target/i386: Suppress coverity warning on fsave/frstor, Richard Henderson, 2022/04/27
- [PULL 1/6] accel/tcg: Assert mmu_idx in range before use in cputlb, Richard Henderson, 2022/04/27
- [PULL 4/6] softfloat: Fix declaration of partsN_compare, Richard Henderson, 2022/04/27
- [PULL 2/6] target/s390x: Fix the accumulation of ccm in op_icm, Richard Henderson, 2022/04/27
- [PULL 5/6] softfloat: Use FloatRelation within partsN_compare,
Richard Henderson <=
- [PULL 6/6] softfloat: Use FloatRelation for fracN_cmp, Richard Henderson, 2022/04/27
- Re: [PULL 0/6] Coverity patch queue, Richard Henderson, 2022/04/27