Re: [PATCH v2 25/26] tests: replace qemu_set_nonblock()

[Thomas Huth]

On 27/04/2022 12.33, Marc-André Lureau wrote:
> Hi
>
> On Wed, Apr 27, 2022 at 1:41 PM Thomas Huth <thuth@redhat.com> wrote:
> > On 26/04/2022 11.27, marcandre.lureau@redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > The call is POSIX-specific. Use the dedicated GLib API.
> >
> > g_unix_set_fd_nonblocking() is also available on Unix-like systems according
> > to its name, I suppose? So what's the advantage of this change?
>
> This is a preliminary patch before the last patch
> (20220426092715.3931705-1-marcandre.lureau@redhat.com/20220426092715.3931705-27-marcandre.lureau@redhat.com/">https://patchew.org/QEMU/20220426092715.3931705-1-marcandre.lureau@redhat.com/20220426092715.3931705-27-marcandre.lureau@redhat.com/)
>
> We should reserve qemu_socket_set_*block() usage to socket-like fd.

Ok, makes sense now, thanks.

Reviewed-by: Thomas Huth <thuth@redhat.com>

PS: In case you respin, it might make sense to add a sentence à la "We're 
going to limit qemu_set_nonblock() to sockets only" to the commit description.