qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 6/6] vl: introduce -audio as a replacement for -soundhw


From: Paolo Bonzini
Subject: Re: [RFC PATCH 6/6] vl: introduce -audio as a replacement for -soundhw
Date: Wed, 27 Apr 2022 16:21:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 4/27/22 15:41, Mark Cave-Ayland wrote:
+                select_soundhw(model, dev->id);
+                g_free(model);
                  break;
+            }
              case QEMU_OPTION_h:
                  help(0);
                  break;

Is it possible to change select_soundhw() to take an AudioDev pointer rather than a string, and then add a new qdev_prop_set_audiodev() function similar to qdev_prop_set_chr() and qdev_prop_set_netdev()?

In reality the underlying QOM property is still a string, but I think having the stronger typing for AudioDev properties is useful and potentially allows for the various *dev backend properties to become QOM links in future.

I didn't consider that because there are just two uses and I don't expect them to grow much, but yes it's possible.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]