[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 2/8] coroutine-lock: release lock when restarting all
From: |
Stefan Hajnoczi |
Subject: |
Re: [RFC PATCH v2 2/8] coroutine-lock: release lock when restarting all coroutines |
Date: |
Thu, 28 Apr 2022 12:21:34 +0100 |
On Tue, Apr 26, 2022 at 04:51:08AM -0400, Emanuele Giuseppe Esposito wrote:
> Current implementation of qemu_co_queue_do_restart
> does not releases the lock before calling aio_co_wake.
> Most of the time this is fine, but if the coroutine
> acquires the lock again then we have a deadlock.
>
> Instead of duplicating code, use qemu_co_enter_next_impl, since
> it implements exactly the same functionality that we
> want.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
It's unclear whether this patch fixes a bug or introduces a new API that
will be used in later patches.
The commit message is a bit misleading: existing functions are not
changed to release the lock when restarting all coroutines.
I think what this commit is actually doing is adding a new API that will
be used in later patches?
signature.asc
Description: PGP signature
[RFC PATCH v2 4/8] async: register/unregister aiocontext in graph lock list, Emanuele Giuseppe Esposito, 2022/04/26