[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] hw/nvme: do not auto-generate uuid
From: |
Christoph Hellwig |
Subject: |
Re: [PATCH v2 3/5] hw/nvme: do not auto-generate uuid |
Date: |
Fri, 29 Apr 2022 17:17:42 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Fri, Apr 29, 2022 at 10:33:34AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Do not default to generate an UUID for namespaces if it is not
> explicitly specified.
>
> This is a technically a breaking change in behavior. However, since the
> UUID changes on every VM launch, it is not spec compliant and is of
> little use since the UUID cannot be used reliably anyway and the
> behavior prior to this patch must be considered buggy.
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
- [PATCH v2 0/5] hw/nvme: fix namespace identifiers, Klaus Jensen, 2022/04/29
- [PATCH v2 1/5] hw/nvme: enforce common serial per subsystem, Klaus Jensen, 2022/04/29
- [PATCH v2 2/5] hw/nvme: do not auto-generate eui64, Klaus Jensen, 2022/04/29
- [PATCH v2 3/5] hw/nvme: do not auto-generate uuid, Klaus Jensen, 2022/04/29
- Re: [PATCH v2 3/5] hw/nvme: do not auto-generate uuid,
Christoph Hellwig <=
- [PATCH v2 5/5] hw/nvme: bump firmware revision, Klaus Jensen, 2022/04/29
- [PATCH v2 4/5] hw/nvme: do not report null uuid, Klaus Jensen, 2022/04/29