[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/7] 9pfs: fix qemu_mknodat() to always return -1 on error on macO
From: |
Christian Schoenebeck |
Subject: |
[PULL 7/7] 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host |
Date: |
Sat, 30 Apr 2022 13:44:42 +0200 |
qemu_mknodat() is expected to behave according to its POSIX API, and
therefore should always return exactly -1 on any error, and errno
should be set for the actual error code.
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id:
<c714b5e1cae225ab7575242c45ee0fe4945eb6ad.1651228001.git.qemu_oss@crudebyte.com>
---
hw/9pfs/9p-util-darwin.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-util-darwin.c b/hw/9pfs/9p-util-darwin.c
index 619c403ba7..a5f8707bb8 100644
--- a/hw/9pfs/9p-util-darwin.c
+++ b/hw/9pfs/9p-util-darwin.c
@@ -124,7 +124,8 @@ int qemu_mknodat(int dirfd, const char *filename, mode_t
mode, dev_t dev)
}
if (!pthread_fchdir_np) {
error_report_once("pthread_fchdir_np() not available on this version
of macOS");
- return -ENOTSUP;
+ errno = ENOTSUP;
+ return -1;
}
if (pthread_fchdir_np(dirfd) < 0) {
return -1;
--
2.30.2
- [PULL 0/7] 9p queue 2022-04-30, Christian Schoenebeck, 2022/04/30
- [PULL 1/7] 9pfs: fix inode sequencing in 'synth' driver, Christian Schoenebeck, 2022/04/30
- [PULL 2/7] 9pfs: fix qemu_mknodat(S_IFREG) on macOS, Christian Schoenebeck, 2022/04/30
- [PULL 3/7] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS, Christian Schoenebeck, 2022/04/30
- [PULL 4/7] 9pfs: fix wrong encoding of rdev field in Rgetattr on macOS, Christian Schoenebeck, 2022/04/30
- [PULL 5/7] 9pfs: fix wrong errno being sent to Linux client on macOS host, Christian Schoenebeck, 2022/04/30
- [PULL 6/7] 9pfs: fix removing non-existent POSIX ACL xattr on macOS host, Christian Schoenebeck, 2022/04/30
- [PULL 7/7] 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host,
Christian Schoenebeck <=
- Re: [PULL 0/7] 9p queue 2022-04-30, Richard Henderson, 2022/04/30