[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 19/50] hppa: move dino_init() from dino.c to machine.c
From: |
Mark Cave-Ayland |
Subject: |
[PATCH v2 19/50] hppa: move dino_init() from dino.c to machine.c |
Date: |
Wed, 4 May 2022 10:25:29 +0100 |
Now that dino_init() is completely decoupled from dino.c it can be moved to
machine.c with the rest of the board configuration.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Helge Deller <deller@gmx.de>
---
hw/hppa/dino.c | 14 --------------
hw/hppa/hppa_sys.h | 2 --
hw/hppa/machine.c | 12 ++++++++++++
3 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index d8baf139d6..6d12c385aa 100644
--- a/hw/hppa/dino.c
+++ b/hw/hppa/dino.c
@@ -399,20 +399,6 @@ static int dino_pci_map_irq(PCIDevice *d, int irq_num)
return slot & 0x03;
}
-DinoState *dino_init(MemoryRegion *addr_space)
-{
- DeviceState *dev;
- DinoState *s;
-
- dev = qdev_new(TYPE_DINO_PCI_HOST_BRIDGE);
- object_property_set_link(OBJECT(dev), "memory-as", OBJECT(addr_space),
- &error_fatal);
- s = DINO_PCI_HOST_BRIDGE(dev);
- sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
-
- return s;
-}
-
static void dino_pcihost_reset(DeviceState *dev)
{
DinoState *s = DINO_PCI_HOST_BRIDGE(dev);
diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h
index ebedecf1c8..7c31dd8396 100644
--- a/hw/hppa/hppa_sys.h
+++ b/hw/hppa/hppa_sys.h
@@ -9,9 +9,7 @@
#include "hw/intc/i8259.h"
#include "hppa_hardware.h"
-#include "dino.h"
-DinoState *dino_init(MemoryRegion *);
DeviceState *lasi_init(MemoryRegion *);
#define enable_lasi_lan() 0
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 49ecb971be..4b753fa346 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -122,6 +122,18 @@ static FWCfgState *create_fw_cfg(MachineState *ms)
return fw_cfg;
}
+static DinoState *dino_init(MemoryRegion *addr_space)
+{
+ DeviceState *dev;
+
+ dev = qdev_new(TYPE_DINO_PCI_HOST_BRIDGE);
+ object_property_set_link(OBJECT(dev), "memory-as", OBJECT(addr_space),
+ &error_fatal);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
+
+ return DINO_PCI_HOST_BRIDGE(dev);
+}
+
static void machine_hppa_init(MachineState *machine)
{
const char *kernel_filename = machine->kernel_filename;
--
2.20.1
- Re: [PATCH v2 15/50] dino.h: add defines for DINO IRQ numbers, (continued)
- [PATCH v2 18/50] dino: remove unused dino_set_timer_irq() IRQ handler, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 12/50] hppa: use new CONFIG_HPPA_B160L option instead of CONFIG_DINO to build hppa machine, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 16/50] dino: define IRQ inputs as qdev GPIOs, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 20/50] dino: use numerical constant for iar0 and iar1 reset values, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 19/50] hppa: move dino_init() from dino.c to machine.c,
Mark Cave-Ayland <=
- [PATCH v2 21/50] dino: move DINO HPA constants from hppa_hardware.h to dino.h, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 23/50] lasi: checkpatch fixes, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 22/50] dino: move from hw/hppa to hw/pci-host, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 24/50] lasi: move memory region initialisation to new lasi_init() function, Mark Cave-Ayland, 2022/05/04
- [PATCH v2 25/50] lasi: move register memory mapping from lasi.c to machine.c, Mark Cave-Ayland, 2022/05/04